Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sgmllib is deprecated #4

Closed
tom-de-smedt opened this issue May 4, 2011 · 3 comments
Closed

sgmllib is deprecated #4

tom-de-smedt opened this issue May 4, 2011 · 3 comments

Comments

@tom-de-smedt
Copy link
Member

sgmllib is deprecated, update with HTMLParser or htmllib.
@smonami
Copy link

smonami commented Aug 16, 2013

So in our codebase, sgmllib has been used in web/init.py , feed/feedparser.py and soup/BeautifulSoup.py.
I believe we just want to remove sgmllib from our web package right?
Other two are third party packages so not sure.

@hayd
Copy link

hayd commented Nov 1, 2014

I think sgmllib is only used in pattern to create an HtmlParser (in web/__init__.py), python 3 ships with one of these in html.parser (perhaps this can "just work" or needs a small api change) as you say. That is, just keep sgmlib for python 2.

I ripped out feedparser and soup as deps which makes it easier for pattern going forward in the pattern3 branch (specifically we don't need to care about fixing feedparser/soup with sgmlib, they've already done it).

@hayd hayd mentioned this issue Nov 1, 2014
Open
35 tasks
hayd pushed a commit to hayd/pattern that referenced this issue Nov 5, 2014
@waylonflinn
Merge pull request clips#4 from hayd/stage1
679b569 
Future stage1 python3:

print, __code__, next, in <dictionary>, relative import fixes

Files to remember to fix for later
pattern/web/json/decoder.py
pattern/web/pdf/pdfdevice.py
pattern/web/pdf/layout.py
pattern/web/pdf/utils.py
@markus-beuckelmann
Copy link
Collaborator

I think sgmllib is only used in pattern to create an HtmlParser (in web/init.py), python 3 ships with one of these in html.parser (perhaps this can "just work" or needs a small api change) as you say.

For future reference: This is exactly what I ended up doing (see commit da00fff), seems to work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tom-de-smedt @smonami @hayd @markus-beuckelmann