Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to executing promises in adblocker-playwright #2006

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Fix to executing promises in adblocker-playwright #2006

merged 1 commit into from
Jun 20, 2021

Conversation

tommulkins
Copy link
Contributor

Implement same solution to adblock-puppeteer to executing promises in playwright.

@tommulkins tommulkins requested a review from remusao as a code owner June 20, 2021 16:24
@tommulkins tommulkins mentioned this pull request Jun 20, 2021
Closed
@remusao remusao added the PR: Bug Fix 🐛 Increment patch version when merged label Jun 20, 2021
remusao
remusao approved these changes Jun 20, 2021
View reviewed changes
Copy link
Collaborator

@remusao remusao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will merge after CI.

@remusao remusao merged commit b001c67 into ghostery:master Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛 Increment patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommulkins @remusao