Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brave.js to use FilterSet #2047

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Fix brave.js to use FilterSet #2047

merged 1 commit into from
Jul 14, 2021

Conversation

mjethani
Copy link
Contributor

Since the APIs in adblock-rs have changed, the Brave benchmarks no longer work. The Engine constructor expects a FilterSet object. Also, the serialize() method is deprecated in favor of serializeCompressed().

This PR updates brave.js to fix these issues.

@mjethani mjethani requested a review from remusao as a code owner July 13, 2021 12:58
remusao
remusao approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@remusao remusao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@remusao remusao added the PR: Internal 🏠 Changes only affect internals label Jul 13, 2021
@remusao remusao merged commit 97dc7c1 into ghostery:master Jul 14, 2021
@mjethani mjethani deleted the fix-brave-use-filterset branch July 14, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjethani @remusao