Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lowercase name ubo-snfe #2092

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Use lowercase name ubo-snfe #2092

merged 1 commit into from
Aug 1, 2021

Conversation

mjethani
Copy link
Contributor

@mjethani mjethani commented Aug 1, 2021

uBlock Origin has changed the name of its Node.js package to use all lower case (gorhill/uBlock@8a33bda).

This is also good for avoiding confusion on filesystems that are case-insensitive.

npm also requires all lower case.

@mjethani mjethani requested a review from remusao as a code owner August 1, 2021 10:20
@remusao remusao added the PR: Internal 🏠 Changes only affect internals label Aug 1, 2021
@remusao remusao merged commit b1ac113 into ghostery:master Aug 1, 2021
@mjethani mjethani deleted the lower-case-ubo-snfe branch August 1, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjethani @remusao