Use ubo-snfe/bundle.min.cjs #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjethani
force-pushed
the
minified-ubo-snfe
branch
from
ffc1a2c to
2a6fccd
Compare
mjethani
commented
Aug 2, 2021
| @@ -10,6 +10,7 @@ requests.json: | |||
|
|
|||
| ./node_modules/ubo-snfe: | |||
| make -C ./blockers/ublock install-nodejs clean | |||
| npx rollup ./node_modules/ubo-snfe/main.js --file ./node_modules/ubo-snfe/bundle.min.cjs --format cjs --context global --plugin terser | |||
There was a problem hiding this comment.
@gorhill I've added the command and dependencies here so we can revert part of gorhill/uBlock@297bcea. I agree that it doesn't belong in the Node.js package itself, esp. because of the dependencies.
remusao
reviewed
Aug 2, 2021
remusao
reviewed
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubo-snfe now includes a
bundle.min.cjsthat is generated at install time using rollup.js.Note that in this patch we regenerate the bundle because we want to remove the bundle generation from the install script (gorhill/uBlock#3794 (comment))