Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move extractHostname() to utils.js #2127

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Move extractHostname() to utils.js #2127

merged 1 commit into from
Aug 6, 2021

Conversation

mjethani
Copy link
Contributor

@mjethani mjethani commented Aug 6, 2021

This moves the extractHostname() function to utils.js.

There were two versions and it uses the one from hosts-lookup.js.

There's also a small change in that the function always returns '' (empty string) now if the match fails, whereas previously it would return undefined for a URL like turn:example.com.

@mjethani mjethani requested a review from remusao as a code owner August 6, 2021 16:42
@remusao remusao added the PR: Internal 🏠 Changes only affect internals label Aug 6, 2021
@remusao remusao merged commit 7342b56 into ghostery:master Aug 6, 2021
@mjethani mjethani deleted the blockers-utils branch August 7, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjethani @remusao