Update uBlock Origin to use npm package

[mjethani]

Using the new StaticNetFilteringEngine class from @gorhill/ubo-core.

[mjethani]

@gorhill please take a look first. It seems to be blocking more requests now! Try to clone https://github.com/mjethani/adblocker and switch to the update-ubo-core branch.

[gorhill]

Weird, I will investigate. What was the previous version?

On my side I used built-in benchmark to compare current master with 1.37.3b4 and I got same result.

[mjethani]

What was the previous version?

@@ -1 +1 @@
-Subproject commit 543e1a3aea0c775ee34b7f168388a9ebaef1b4c5
+Subproject commit d9adf5a6fb688d470e67204501fdee176f9b4d4a

If it helps, I tried with enableWASM() and I also checked that the type value is being propagated to the engine. This must be something wrong with the way I'm using it here or otherwise with the changes that involve the moving around of the parser, compiler, etc.

[mjethani]

This works until gorhill/uBlock@65f0909

[mjethani]

This works until gorhill/uBlock@65f0909

By this I mean that it works in that commit too. It probably broke in the one that followed. Let me confirm this.

[mjethani]

This works until gorhill/uBlock@65f0909

By this I mean that it works in that commit too. It probably broke in the one that followed. Let me confirm this.

Confirmed. It broke in gorhill/uBlock@7cd583a. In that commit it blocks 85,131 requests. It should block 82,388 requests.

[gorhill]

When I compare on my side using built-in benchmark which uses all default filter lists, I get 94,560 for both before and after that commit. This suggests the issue is in a code path not used by the extension.

[mjethani]

When I compare on my side using built-in benchmark which uses all default filter lists, I get 94,560 for both before and after that commit. This suggests the issue is in a code path not used by the extension.

It's almost certainly in platform/nodejs/index.js.

[gorhill]

Looks like loadJSON('build/publicsuffixlist.json') is returning an empty string.

---

Right, it's empty, it's just "".

[mjethani]

Looks like loadJSON('build/publicsuffixlist.json') is returning an empty string.

gorhill/uBlock#3807

[mjethani]

@gorhill @remusao fixed now and ready for review.

[mjethani]

@gorhill if you publish a new version to npm, I'll update this patch to use the npm version directly just as we do with adblock-rs and @adguard/tsurlfilter.

[gorhill]

@gorhill if you publish a new version to npm, I'll update this patch to use the npm version

Done: https://www.npmjs.com/package/@gorhill/ubo-core

[mjethani]

@gorhill if you publish a new version to npm, I'll update this patch to use the npm version

Done: https://www.npmjs.com/package/@gorhill/ubo-core

@remusao I've updated the patch now to remove the git submodule and use the npm package directly.