Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UBlockOrigin#deserialize() consistent #2140

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Make UBlockOrigin#deserialize() consistent #2140

merged 1 commit into from
Aug 10, 2021

Conversation

mjethani
Copy link
Contributor

@mjethani mjethani commented Aug 10, 2021 •
edited
Loading

StaticNetFilteringEngine#deserialize() returns a promise already.

@mjethani mjethani requested a review from remusao as a code owner August 10, 2021 07:05
@mjethani mjethani changed the title Make UBlockEngine#deserialize() consistent Make UBlockOrigin#deserialize() consistent Aug 10, 2021
@remusao remusao added the PR: Internal 🏠 Changes only affect internals label Aug 10, 2021
@remusao remusao merged commit 56d3b20 into ghostery:master Aug 10, 2021
@mjethani mjethani deleted the patch-1 branch August 10, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao Awaiting requested review from remusao remusao is a code owner

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjethani @remusao