Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific versions of the engines #2145

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

mjethani
Copy link
Contributor

All of the engines are under development and are not following semantic versioning. Therefore, similar to git submodules, we should use specific versions of the engines when installed from the npm registry.

@mjethani mjethani requested a review from remusao as a code owner August 10, 2021 09:49
@remusao remusao added the PR: Internal 🏠 Changes only affect internals label Aug 10, 2021
@remusao remusao merged commit c4fd8b3 into ghostery:master Aug 10, 2021
@mjethani mjethani deleted the use-specific-engine-versions branch August 10, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants