Handle 'ping' type from puppeteer #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remusao
reviewed
Aug 11, 2021
mjethani
force-pushed
the
default-type-other
branch
from
a9e588a to
19eeca9
Compare
mjethani
changed the title
mjethani
force-pushed
the
default-type-other
branch
from
19eeca9 to
104daf6
Compare
mjethani
commented
Aug 11, 2021
remusao
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from here: #2125 (comment)
adblock-rs crashes if the value is
undefined.It's not clear why we are getting
pingfrom puppeteer and this needs to be investigated further. It could have been something wrong with my setup.See #2149 (comment)