Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up file locations #2164

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Clean up file locations #2164

merged 1 commit into from
Aug 12, 2021

Conversation

mjethani
Copy link
Contributor

This moves the data set generation scripts into a scripts directory and the filter lists into a lists directory.

@mjethani mjethani requested a review from remusao as a code owner August 12, 2021 16:11
@mjethani
Copy link
Contributor Author

@remusao I'm not sure about the Python stuff. I've left it as it is. Let me know if you want to move it too.

@remusao remusao added the PR: Internal 🏠 Changes only affect internals label Aug 12, 2021
remusao
remusao approved these changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@remusao remusao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's leave the Python stuff as is for now since it would need to be adapted to run with a different folder structure.

@remusao remusao merged commit c8fc72e into ghostery:master Aug 12, 2021
@mjethani mjethani deleted the clean-up-file-locations branch August 12, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjethani @remusao