Update peer dependency on Electron #2228
Conversation
This will hopefully make the dependency less strict for new stable and beta versions, so they can be installed without --force.
| @@ -34,7 +34,7 @@ | |||
| "test": "nyc mocha --config ../../.mocharc.js" | |||
| }, | |||
| "peerDependencies": { | |||
| "electron": "11.x || 12.x || 13.x" | |||
| "electron": "^11.0.0" | |||
There was a problem hiding this comment.
I think this needs to be either * or x, otherwise it will not allow major version updates.
| "electron": "^11.0.0" | |
| "electron": "*" |
There was a problem hiding this comment.
I just check this on https://semver.npmjs.com/ and you are correct, so I experimented with the syntax, and it turns out we can do >11 to specify that everything starting at 11 is okay, including major versions.
There was a problem hiding this comment.
The reason I used >11 instead of >10, which is in line with current, is that Electron 11 has reached end of life on the 31st of August.
There was a problem hiding this comment.
Just to clarify, is the intent to also include 11 or to exclude it and only support from 12 onward? If the former, then should it be >=11?
There was a problem hiding this comment.
The intent here is to exclude 11, and specify it to mean 12 and above, so we could also use >=12. Or in case you still want to support 11, it's indeed correct to use >=11. Which version has your preference?
There was a problem hiding this comment.
Both are ok, I just wanted to confirm my understanding. I thought from the previous comment that you meant to exclude 10 but include 11. Thank you!
|
Thank you @Jelmerro! |
This will hopefully make the dependency less strict for new stable and beta versions, so they can be installed without --force.