-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch FileNotFoundException when sending file body #471
Conversation
In general, I dislike the practice of the framework surfacing an exception to the client. If the application developer wants to do that, fine, but elsewhere we provide a bare 500 response and log the issue. I think I'd like to mirror that here. |
@ztellman Do you mean how |
But let's finish with #485 first, these 2 have a lot of overlapping changes. |
Sorry if I misattributed where that code came from, but even if I was the one that originally did it, I think it's a mistake. |
@ztellman Oh, no problem with that. I just think that in such a case it makes sense to implement new behavior in a separated PR not to mess up the history of changes. WDYT? |
…ending data and suppress stack trace printing into the response
@ztellman Merged with the latest master changes (notably |
Fixes #459.
In general, we need to be more careful with the cleanup procedure and any time
send-message
failed for whatever uncaught reason close the connection. This specific just PR covers one of the obvious failures that the user might face. /cc #457.