Fix uberjar generation #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, making an uberjar with lein uberjar would fail with:
Syntax error macroexpanding at (core.clj:95:19).
Execution error (IllegalArgumentException) at clooj.utils/get-os (utils.clj:114).
No matching method getProperty found taking 1 args for class java.lang.Class
It doesn't *seem* to be necessary any longer. Also, once we've removed it, we no longer need to use --add-exports java.desktop/com.apple.eawt=ALL-UNNAMED when running the uberjar on macOS.
NoahTheDuke
approved these changes
May 5, 2024
| @@ -111,7 +111,7 @@ | |||
| ;; identify OS | |||
|
|
|||
| (defn get-os [] | |||
| (string/lower-case (.getProperty System "os.name"))) | |||
| (string/lower-case (System/getProperty "os.name"))) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After these changes,
lein uberjarsucceeds on my machine, and double-clickingtarget/clooj-0.5-standalone.jaropens Clooj.To make it easy for folks to run Clooj, I think we can initially just create the uberjar locally, make a GitHub release manually, and attach the uberjar to the release.