Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: user-guide: add list of :fn/* #605

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Jul 11, 2024

Added a complete list of :fn/* functions that are available in the map syntax. This includes everything in impl/xpath.clj, including :fn/has-string.

Please complete and include the following checklist:

  • [ x] I have read CONTRIBUTING and the Etaoin Developer Guide.

  • [ x] This PR corresponds to an issue that the Etaoin maintainers have agreed to address.

  • [ x] This PR contains test(s) to protect against future regressions

  • [ x] I have updated CHANGELOG.adoc with a description of the addressed issue.

Added a complete list of :fn/* functions that are available in the map
syntax. This includes everything in impl/xpath.clj, including
:fn/has-string.
Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @dgr! You ok with making minor requested tweaks?

CHANGELOG.adoc Outdated Show resolved Hide resolved
doc/01-user-guide.adoc Outdated Show resolved Hide resolved
@dgr
Copy link
Contributor Author

dgr commented Jul 11, 2024

No issues. I'll make updates and push another commit. You'll probably have to squash when you merge.

@lread
Copy link
Collaborator

lread commented Jul 11, 2024

Yep that's cool, we squash when we merge.

@lread
Copy link
Collaborator

lread commented Jul 12, 2024

It all looks great, thanks, @dgr. Testing web drivers on CI is not the smoothest thing. Ubuntu is usually fine, but Windows fails often and MacOS sometimes. It looks like a MacOS job went weird. I canceled it and will retry once GitHub lets me. I'll merge your change once I get green jobs.

@lread lread merged commit 0de187a into clj-commons:master Jul 12, 2024
53 checks passed
@dgr dgr deleted the dgr-doc-map-fns branch July 12, 2024 18:35
lread added a commit that referenced this pull request Jul 28, 2024
…ridriver-logs

* origin/master:
  Ignore emacs backup files (#609)
  Add :fn/index as alias for :index in map syntax (#603) (#608)
  doc: thank Dave Roberts for contribution [skip ci] (#607)
  Add support for shadow DOM #604 (#606)
  doc: user-guide: add list of :fn/* (#605)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants