Use Namespace/find to see if nrepl is running, not require #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nha
added a commit
to nha/pretty
that referenced
this pull request
Aug 7, 2023
Before this change, adding this library in babashka yields an error:
```
(Namespace/find 'some.ns)
^--- No matching method find found taking 1 args
```
This is introduced in a recent change (clj-commons#95), the previous version 2.0 works fine.
This is because Namespace/find is not compiled. But `find-ns` is and is
equivalent
https://github.com/clojure/clojure/blob/38bafca9e76cd6625d8dce5fb6d16b87845c8b9d/src/clj/clojure/core.clj#L4126-L4130
nha
added a commit
to nha/pretty
that referenced
this pull request
Aug 7, 2023
…hka/babashka) yields an error: ``` (Namespace/find sym) ^--- No matching method find found taking 1 args ``` This has been introduced in a [recent change](clj-commons#95). Pretty version 2.0 is usable from babashka. This is because `Namespace/find` is not compiled in babashka (probably considered an implementation detail). But `clojure.core/find-ns` is included and is equivalent https://github.com/clojure/clojure/blob/38bafca9e76cd6625d8dce5fb6d16b87845c8b9d/src/clj/clojure/core.clj#L4126-L4130 This change proposes to replace `Namespace/find` with `clojure.core/find-ns`.
nha
added a commit
to nha/pretty
that referenced
this pull request
Aug 7, 2023
…hka/babashka) yields an error: ``` (Namespace/find sym) ^--- No matching method find found taking 1 args ``` This has been introduced in a [recent change](clj-commons#95). Previous versions (I checked 2.0) are usable from babashka. This is because `Namespace/find` is not compiled in babashka (probably considered an implementation detail). But `clojure.core/find-ns` is included and is equivalent https://github.com/clojure/clojure/blob/38bafca9e76cd6625d8dce5fb6d16b87845c8b9d/src/clj/clojure/core.clj#L4126-L4130 This change proposes to replace `Namespace/find` with `clojure.core/find-ns`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93