Should node/coerce also be implemented for nil?

[jespera]

If I call (node/coerce nil) I get an error: (I've added line-breaks in the error message)

IllegalArgumentException No implementation of method: :coerce of protocol: 
#'rewrite-clj.node.protocols/NodeCoerceable found for class: nil  
clojure.core/-cache-protocol-fn (core_deftype.clj:568)

However, calling (parser/parse-string "nil") returns a node <token: nil>

Is this behavior by design? Would it conflict with anything to extend the NodeCoerceable protocol to nil-values?

[xsc]

No, it's perfectly reasonable to implement the protocol for nil values.

[jespera]

Would you accept a pull-request or is it not a thing you'd want in the main code-base?

[xsc]

@jespera I'll gladly accept a PR for this! Sorry for being kinda vague in the previous comment. :)

[jespera]

#53

[xsc]

Released as 0.6.0.

Release Notes

[jespera]

Very nice! Thanks a lot for the quick response. 👍