Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from-cljsjs should have a target option #6

Closed
martinklepsch opened this issue Dec 23, 2014 · 7 comments
Closed

from-cljsjs should have a target option #6

martinklepsch opened this issue Dec 23, 2014 · 7 comments
Labels

Comments

@martinklepsch
Copy link
Member

No description provided.

@Deraen
Copy link
Member

Deraen commented Jan 3, 2015

Probably not needed?

@martinklepsch
Copy link
Member Author

When using :none I would think that you want to make sure it's in public/
(if applicable). I think that was what I had in mind when filing that
issue.

Might be totally wrong though, things have been changing fast recently :)

On Saturday, January 3, 2015, Juho Teperi notifications@github.com wrote:

Probably not needed?


Reply to this email directly or view it on GitHub
#6 (comment).


Martin
http://martinklepsch.org http://martinklepsch.org?ref=email

@Deraen
Copy link
Member

Deraen commented Jan 3, 2015

Yeah this would probably be wrong solution for that problem.

@martinklepsch
Copy link
Member Author

Isn't that exactly what target is meant for in those other tasks?


Martin
http://martinklepsch.org http://martinklepsch.org?ref=email

@Deraen
Copy link
Member

Deraen commented Jan 3, 2015

Yeah. That might also be wrong solution.

Rc5 will include improved sift task which can be used to move stuff around inside fileset.
Sift could also in future support adding files from jars to fileset, making from-jars and possibly from-webjars unnecessary.

@Deraen
Copy link
Member

Deraen commented Jan 5, 2015

I'm doing this to serve files from public/ prefix:

(from-cljsjs)
(sift :move {#"^cljsjs/" "public/cljsjs/"})

I think it's best to just leave moving files to to other tasks.

@martinklepsch
Copy link
Member Author

Agreed on the sift "pattern". Should we remove the target option from those other tasks as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants