Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/price byte #29

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Fix/price byte #29

merged 3 commits into from
Apr 5, 2023

Conversation

detectivekim
Copy link
Contributor

The price can be uint256 instead of uint128.

@detectivekim detectivekim changed the base branch from main to fix/price-index April 4, 2023 18:06
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (fix/price-index@8b95193). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                 @@
##             fix/price-index      #29   +/-   ##
==================================================
  Coverage                   ?   99.23%           
==================================================
  Files                      ?        9           
  Lines                      ?      521           
  Branches                   ?       93           
==================================================
  Hits                       ?      517           
  Misses                     ?        3           
  Partials                   ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

# Conflicts:
#	contracts/markets/GeometricPriceBook.sol
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Test with 0e50353.

  • EHET : Empty heap with empty segment tree
  • EHDT : Empty heap with dirty segment tree
  • FHET : Filled heap with empty segment tree
  • FHFT : Filled heap with filled segment tree
    No longer impact gas costs

@onemonster onemonster merged commit c48f306 into fix/price-index Apr 5, 2023
@onemonster onemonster deleted the fix/price-byte branch April 5, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants