-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battery percentage #24
Comments
Preheat comes from 5.04. It was a feature a thought to implement a some point, but they did it fisrt^^ About bettery percentage: if you display numbers, they sould really tell something. Problem with battery percentage is that it's really inaccurate. It strongly depends on the discharge curve of your very brand and model of battery, and discharge curve are usually very flat around 3.6V, so 50% can mean anything between 20% and 80%. That's why I find this feature almost useless. A large bar is as informative as a small bar plus an unreliable percentage. |
@ClockSelect how about to store discarge table in the dataflash? Also do not use hardcoded values for 0% 10% 20% ... 100% percents, instead using configurable pairs, like DNA does (% - volts). This is how looks my Samsung 25R setup for DNA
Also i have an idea to create Escribe software analog for myEvic firmwares. Since sources are open and highly customizable will be easy to move any settings to the dataflash. |
Yes, I thought about it. The data you're posting will not be the same after 30 more cycles of your battery. The curve is so flat between 3.4 and 3.8V that the thiniest perturbation will defeat any attempt to tell anything relevant between "Almost full" and "Almost empty". The default curve of the VTC is not-so-bad, and the battery management of this box is in fact pretty good. You won't pull more than 2~300mAh more from your battery by tweaking the numbers. It's not worth the pain. |
I'll even tell you more: it was my first purpose when I decided to disassemble that firmware. |
@ClockSelect 300 mAh is good achievement, in case when your battery is 2500 mAh maximum. |
I may try to replace the % table of the box by yours and see if it improves accuracy, but it will mostly improve acuracy for users of Samsung 25R. |
Maybe I can interpolate precentage juste like voltages, so having a table by 10% is maybe not an absolute necessity. Would just take more ROM and flash space. |
I think we need better algorithm for battery percentage calculation. Like this: There are some tables for DNA boards LG HG2
Samsung 30Q
Sony VTC4
Sony VTC5
|
Precious tables. I'ill take them. |
A menu with batteries list seems to me too hazardous and there is too much batteries plus alots of fake or used 100cycles batteries, well I find tables and battery list not reliable in my opinion +too much different batteries on market. May-be that's what you are thinking : Or make OS record the differences of voltages Sorry if that's obvious or wrong. |
I agree. |
@TBXin: I'm trying your tables - they won't like 'em. |
@ClockSelect whom? |
Users :) That's because they have a less optimistic-looking over the run than the generic curve. |
My battery become weak when the original power bar is still at half. |
"Weak Battery" appears when vaping at the selected power would bring or (brings) your battery voltage below 2.9v. You can see it when selecting the real-time battery voltage on the third info line of the main display. Starting at 3.4v, this is a 0.6v voltage sag. Internal resistance increases with battery cycles and usage; the more it's used at high Amps, the more it increases. Good guenuine new batteries starts with around 0.02 Ohms of internal rez, average chinese battery are more around 0.1 Ohms, good used batteries are somewhere in-between. 3.4v is can never be a full battery; it's an almost empty battery - around 10-15%. There's no problem, afaik, with original FW calculations. |
This is cool! |
Could you add the LG HE4 (yellow batteries) table in the next build? |
And this why i suggest to create "Custom" or something like this menu item, which will be pointing to the curve in the dataflash that can be configured via NFE or directly in the device. |
Even better. Great idea, make it configurable via NFE. It would be kinda hard inputting those numbers directly on device. |
Added HE4 data. |
I tried to lower the cut-off voltages, but unfortunately we cannot really do that. |
No sense to make cut off to lower than 3.2-3.3v. If i remember correctly stock firmwares completely shuts down when voltage become lower than 3.0v. |
Ok, something is not right with that HE4 profile I sent, for example if it is selected it shows 53%, when switched to GEN, it is 74%, but if I go back to HE4 once again now it is 65%. I'm not much of a coder yet, but I will take a look when I get home from work. edit: It is just battery voltage readout jumping. |
@mkrajinovic will be great if you can also provide battery voltage for same cases. |
I will see what I can do when I get home. |
Yes, battery charging screen is still at 10% resolution. I may change that if you want, but anyway voltage on charge is off by at least +0.5V so it's not really significant. |
53% to 65% on the HE4 is around a 0.15V gap, it's usual on release from a regular vaping power drain. |
No, no. Don't change it. I mentioned that only for information. I thought that you hadn't noticed it ;) |
This is a very nice firmware, so many great features and I just saw that joytech also implemented preheat in their newest firmware v5.04(Sep 2nd). Did they steal that function code from you?
There is just one Battery percentage feature missing that I used in NFirmwareEditor.
Is it possible to add?
I have also attached hex replace code from NFirmwareEditor using Evic VTC Mini 3.01 version firmware.
3.01_batt_prc7.zip
The text was updated successfully, but these errors were encountered: