Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(833): Do not clone query plan during execution #981

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 14, 2024

Description of Changes

Fixes #833

Perf numbers on my machine:

Benchmarking incr-join: Collecting 100 samples in estimated 5.01
incr-join               time:   [5.0575 µs 5.0914 µs 5.1521 µs]
                        change: [-19.535% -18.714% -17.870%] (p = 0.00 < 0.05)
                        Performance has improved.

Benchmarking query-indexes-multi: Collecting 100 samples in esti
query-indexes-multi     time:   [1.0330 µs 1.0387 µs 1.0457 µs]
                        change: [-13.574% -12.820% -12.213%] (p = 0.00 < 0.05)
                        Performance has improved.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

No changes semantically; should be covered by existing tests.

@joshua-spacetime
Copy link
Collaborator

Not sure what's going on here

full-join               time:   [282.30 µs 283.82 µs 286.06 µs]
                        change: [+11.033% +11.400% +11.830%] (p = 0.00 < 0.05)
                        Performance has regressed.

crates/core/src/vm.rs Outdated Show resolved Hide resolved
@@ -271,7 +272,7 @@ fn iter_by_col_range<'a>(
ctx: &'a ExecutionContext,
db: &'a RelationalDB,
tx: &'a TxMode,
table: DbTable,
table: &'a DbTable,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's causing the regression in full-join, but this is extra indirection.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear where this regression is coming from at the moment.

@bfops bfops added include-in-perf-test release-any To be landed in any release window and removed include-in-perf-test labels Mar 15, 2024
@joshua-spacetime joshua-spacetime changed the title perf(833): don't clone QueryExpr perf(833): Do not clone query plan during execution Mar 15, 2024
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Mar 15, 2024
Merged via the queue into master with commit 5601c18 Mar 15, 2024
6 checks passed
@joshua-spacetime joshua-spacetime deleted the centril/query-expr-borrow branch March 15, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not clone query plans
3 participants