Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing tests #494

Merged
merged 2 commits into from
Jan 27, 2018
Merged

Disable failing tests #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f3b06a
Disable CLJS-1.9 test on JDK7
ckoparkar Jan 26, 2018
722b10f
Fix CLJS test failures on JDK9
ckoparkar Jan 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ matrix:
jdk: oraclejdk8
after_success: bash <(curl -s https://codecov.io/bash) -f target/coverage/codecov.json

exclude:
# CLJS-1.9 doesn't build on JDK7. This is because of a dependency on the
# google/closure-compiler which requires JDK8 or higher.
# https://github.com/google/closure-compiler/wiki/Releases#september-10-2017-v20170910
- env: VERSION=1.9 TARGET=test-cljs
jdk: openjdk7

fast_finish: true # don't wait for allowed failures before build finish
allow_failures:
- env: VERSION=master TARGET=test-clj
Expand Down
11 changes: 10 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
VERSION ?= 1.9
export CLOVERAGE_VERSION = 1.0.11-SNAPSHOT

# The test-cljs target needs to be modified if working with JDK9
JAVA_VERSION = $(shell lein version | cut -d " " -f 5 | cut -d "." -f 1-2)

.source-deps:
lein source-deps
touch .source-deps
Expand All @@ -13,7 +16,13 @@ test-clj: .source-deps
lein with-profile +$(VERSION),+test-clj test

test-cljs: .source-deps
lein with-profile +$(VERSION),+test-cljs test
if [ "$(JAVA_VERSION)" = "9.0" ] || [ "$(JAVA_VERSION)" = "9-internal" ]; then \
lein with-profile +$(VERSION),+test-cljs \
update-in :jvm-opts concat '["--add-modules" "java.xml.bind"]' \
-- test; \
else \
lein with-profile +$(VERSION),+test-cljs test; \
fi

eastwood: .source-deps
lein with-profile +$(VERSION),+test-clj,+test-cljs,+eastwood eastwood
Expand Down