Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #497 Auto-publish to clojars #498

Merged
merged 3 commits into from
Jan 29, 2018

Conversation

gonewest818
Copy link
Contributor

This seems likely to conflict with the changes @ckoparkar has in #494, so I'm submitting this mainly for visibility. An early look. I can take care of the reconciliation after #494 is merged.

The changes are analogous to what was done in clojure-emacs/orchard#10, follow the link for deeper explanation.

Left to do:

  • debug the orchard build (as of now the deploy job isn't actually deploying)
  • add encrypted environment variables where noted in .travis.yml

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the readme (if adding/changing middleware)

Thanks!

@gonewest818 gonewest818 force-pushed the 497-auto-publish-clojars branch 2 times, most recently from 0585434 to 795ce25 Compare January 28, 2018 20:15
@gonewest818
Copy link
Contributor Author

I rebased this to master, resolving the conflicts with the fix to #494 contributed by @ckoparkar. Build is clean (except for broken eastwood and cljfmt checks that are also broken on master).

@bbatsov same drill as with the orchard repl, you need to encrypt the appropriate Clojars credentials and paste them into .travis.yml. Note you cannot copy and paste the same strings as in the orchard config because the encryption keys are unique to each repo.

@bbatsov bbatsov merged commit aea8dbe into clojure-emacs:master Jan 29, 2018
@bbatsov
Copy link
Member

bbatsov commented Jan 29, 2018

Note you cannot copy and paste the same strings as in the orchard config because the encryption keys are unique to each repo.

Yeah, I assumed as much when I saw yesterday travis was asking for the repo name and generated different encryption for the same strings in orchard and cider-nrepl. Thanks for the heads up, though!

@gonewest818 gonewest818 deleted the 497-auto-publish-clojars branch January 29, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants