Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite indentation testing code #26

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Rewrite indentation testing code #26

merged 3 commits into from
Aug 10, 2022

Conversation

axvr
Copy link
Member

@axvr axvr commented Aug 8, 2022

Benefits of new solution:

  1. Faster (runs indentation tests in parallel)
    • On GitHub Actions, the tests now finish >10 seconds quicker, but we will see a greater benefit when I add more indentation tests (hopefully soon).
  2. Less code
  3. Adding new indentation test cases doesn't require editing the indent_test.clj Clojure file anymore
  4. Fixed issues with the test vimrc so tests now work on newer Vim versions (previously they only worked on Vim 8.1 and below)
  5. Can now set different config options per-test
  6. Indentation tests now all pass on my computer

Now we're in a good position to start adding more indentation tests.

New implementation is:

  - Faster
  - Smaller
  - Configurable
  - Easier to add new tests

As a bonus all the tests now pass on my machine (previously a couple of
tests failed on my machine, but passed in CI)!
@axvr axvr changed the title Rewrite indentation testing code and quick refactor of clj directory Rewrite indentation testing code Aug 8, 2022
@axvr axvr merged commit b21188c into master Aug 10, 2022
@axvr axvr deleted the refactor branch August 10, 2022 17:16
@axvr axvr mentioned this pull request Apr 27, 2023
16 tasks
@axvr axvr added the indentation Affects indentation label Jun 23, 2023
@axvr axvr added this to the Indentation overhaul milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
indentation Affects indentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant