Prevent sample from being skipped #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this! I'll look more deeply at your proposed fix tonight. Cheers! |
|
Np ! In addition, I took things a little further and added a few features
If you're interested I can PR these as well |
|
Absolutely! I'd love to take a look at those new features!
…On Mon, Jan 27, 2020 at 8:54 AM Rémi Collin ***@***.***> wrote:
Np !
In addition, I took things a little further and added a few feature
- Stereo outputs
- "Loop switch" which restart playback at the end of the file
- Deactivate autoplay when "Trig" input is patched.
If you're interested I can PR these as well
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6?email_source=notifications&email_token=AAKPKM5VSMPT3G4KEMPALGLQ74GUVA5CNFSM4KMBLEC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKAHH4A#issuecomment-578843632>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKPKM7NJTM6EF5R47TYYE3Q74GUVANCNFSM4KMBLECQ>
.
|
|
Remi, did your other PR contain all of the items that you wanted updated? If so, can I delete this PR? |
|
Yes, should have closed it you're right ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that samples were randomly not playing. I'm not sure if this line has another use, so I just commented it out, but doing so fix the issue.