Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong time calculation #8

Closed
Thomas-MMJ opened this issue Dec 9, 2022 · 0 comments
Closed

wrong time calculation #8

Thomas-MMJ opened this issue Dec 9, 2022 · 0 comments

Comments

@Thomas-MMJ
Copy link

your calculation of time is based on steps, but you need to multiply steps times accumulations to get the correct eta estimate,

so currently accumulation 2, and steps 1000, it gives eta of 1000, but actual is 2000.
timh added a commit to timh/lora that referenced this issue Dec 9, 2022
@timh
fix global steps tracking & --save_steps intermittent saves (cloneofs…
211605a 
…imo#6, cloneofsimo#8)
cloneofsimo added a commit that referenced this issue Dec 10, 2022
@cloneofsimo
Merge pull request #11 from timh/fix-incorrect-global-steps
59e122a 
fix global steps tracking & --save_steps intermittent saves (#6, #8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cloneofsimo @Thomas-MMJ