Switched to use Pendulum's C timezone implementation #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@movermeyer Thanks for this! Looks like there are some conflicts now. Is this otherwise ready? |
thomasst
previously requested changes
Oct 18, 2019
movermeyer
changed the title
movermeyer
force-pushed
the
tzinfo
branch
4 times, most recently
from
5583e76
to
39f40f8
Compare
movermeyer
force-pushed
the
tzinfo
branch
3 times, most recently
from
03a53b6
to
2b3eb27
Compare
movermeyer
commented
Dec 29, 2020
movermeyer
force-pushed
the
tzinfo
branch
4 times, most recently
from
9ba62be
to
42b4f5c
Compare
movermeyer
changed the title
NickG123
reviewed
Dec 29, 2020
movermeyer
force-pushed
the
tzinfo
branch
2 times, most recently
from
5d85d29
to
509e78b
Compare
movermeyer
force-pushed
the
tzinfo
branch
4 times, most recently
from
d95048b
to
8e67d21
Compare
movermeyer
force-pushed
the
tzinfo
branch
3 times, most recently
from
05c671d
to
6cd055a
Compare
… against other libraries (ex. `from pendulum.parsing import parse_iso8601 as parse_datetime`)
thomasst
reviewed
Jun 29, 2021
module.c
Outdated
| } | ||
|
|
||
| #if PY_VERSION_AT_LEAST_37 |
There was a problem hiding this comment.
Should we use
#if PY_VERSION_HEX < 0x03070000 || (PYPY_VERSION && PYPY_VERSION_NUM < 0x07030600)
utc = new_fixed_offset(0);
#else
utc = PyDateTime_TimeZone_UTC;
#endif
to be most compatible?
There was a problem hiding this comment.
@thomasst Make sense. Added as SUPPORTS_37_TIMEZONE_API
There was a problem hiding this comment.
I tested that the build works with pypy v7.3.5 using:
docker run -it --rm=true -v $(dirname `pwd`):/app pypy bash
cd /app
pypy3 setup.py test
It fails some of the tests due to difference in the error message printout, but runs fine.
I have also tested against the nightly build of the py3.7 branch, which includes their changes. For this I used a slightly updated version of linnik/pypy3-nightly-docker and the same test methodology as above. It had the same results.
movermeyer
force-pushed
the
tzinfo
branch
2 times, most recently
from
de3cf00
to
e2dea9c
Compare
Removes dependency on pytz. Maintains the same error messages so its backwards compatible with 2.0.x versions.
thomasst
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes dependency on pytz.
Maintains the same error messages so it's backwards compatible with 2.0.x versions.
Resolves #45 (See that issue for performance discussion), and fixes #101