Revert subscription eventTypes change #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeaky-pl
changed the title
wojcikstefan
approved these changes
Feb 27, 2024
|
BTW it kept working so-so because sync-engine will resync every hour even if we don't receive a webhook 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally in #664 we starting passing
eventTypes. Today when I was doing unrelated changes I realized that the changes aren't arriving close to realtime and the webhooks about changes in the calendar are not delivered anymore. I think Google jinxed themselves and the webhooks API is not working correctly with their new APIs.Through several manual tests I confirmed that fetching the events works while filtering with
eventTypes, but webhooks are not delivered (although the subscription is created successfully) with the new parameter.The rest of the logic will keep working as expected because we only update a timestamp in the database in the API pods, and then in the SYNC pods we fetch changes between the time we last synced and that timestamp. Since sync pods filter out by
eventTypeseven if we receive webhook about changes we are not interested we will just fetch empty resultset from Google.