Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template out version #67

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Template out version #67

merged 1 commit into from
Sep 13, 2024

Conversation

jtaleric
Copy link
Member

@jtaleric jtaleric commented Sep 13, 2024 •
edited
Loading

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

Allow the user to override the version in examples

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@jtaleric
Template out version
d12c723 
Allow the user to override the version in examples

Signed-off-by: Joe Talerico aka rook <joe.talerico@gmail.com>
@jtaleric jtaleric mentioned this pull request Sep 13, 2024
Merged
@shashank-boyapally
Copy link
Collaborator

/lgtm

vishnuchalla
vishnuchalla approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishnuchalla vishnuchalla merged commit b337b72 into cloud-bulldozer:main Sep 13, 2024
3 checks passed
@jtaleric jtaleric deleted the version-tmpl branch September 13, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuchalla vishnuchalla vishnuchalla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtaleric @shashank-boyapally @vishnuchalla