Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releng - try a windows build #177

Merged
merged 16 commits into from
Jan 10, 2024
Merged

releng - try a windows build #177

merged 16 commits into from
Jan 10, 2024

Conversation

kapilt
Copy link
Contributor

@kapilt kapilt commented Jan 9, 2024

see what happens.

@kapilt
Copy link
Contributor Author

kapilt commented Jan 9, 2024

somewhat of a surprise, windows builds worked ootb, https://github.com/cloud-custodian/tfparse/actions/runs/7466017271
cibuildwheel ❤️

Copy link
Member

@ajkerrigan ajkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, yay cibuildwheel doing its thing 😎

Comment on lines 16 to 17
# - runner: ubuntu-latest
# cibw_arch: aarch64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping this commented because it's temporary and we want the visual reminder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, those are coming back, just wanted to reduce the cycle time on testing the windows specific portion of the build.

@kapilt
Copy link
Contributor Author

kapilt commented Jan 10, 2024

hmm.. doesn't look like windows works in practice, even though it builds, ci failing with
FAILED tests/test_tfparse.py::test_parse_no_dir - ffi.error: symbol 'free' not found in library 'D:\a\tfparse\tfparse\tfparse.cp312-win_amd64.pyd': error 0x7f

@kapilt
Copy link
Contributor Author

kapilt commented Jan 10, 2024

the function doesn't appear to be exported is the underlying issue, the parse function is, as super hacky thing on windows we're just going to avoid calling free for now and that means accepting a memory leak :/ the common usage for c7n_left though this is non material as we're effectively exiting after a parse, but its a strong caveat for library usage on win32

@kapilt kapilt merged commit e2380c3 into main Jan 10, 2024
8 checks passed
@kapilt kapilt deleted the releng/win32 branch January 10, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants