This repository has been archived by the owner on Jun 18, 2024. It is now read-only.
Add font awesome as a depedency #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process of documenting how the sidenav element works I noticed we didn’t have font-awesome included which resulted in the glyphs not being displayed properly. Added the library as a dependency and included some build scripts that are run automatically on `npm run build` The `copy-fontawesome-css` script is weird looking because I alter the paths required in the CSS file to match our current file structure. We currently use `/font` so that is where the browser should look for font awesome fonts. I raised some related concerns in cloud-gov/cg-style-gem#5, which could change some parts of this implementation
jeremiak
pushed a commit
that referenced
this pull request
Apr 22, 2016
Include font-awesome in page after #57
|
I'm closing this PR because it isn't the route we want to go. Since we're pulling in font-awesome just for some carets for the sidenav, we are just going to style the carets with pure CSS to reduce the footprint of using |
jeremiak
pushed a commit
that referenced
this pull request
May 9, 2016
Include font-awesome in page after #57
jeremiak
pushed a commit
that referenced
this pull request
Jun 1, 2016
Include font-awesome in page after #57
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of documenting how the sidenav element works I noticed we didn’t have font-awesome included which resulted in the glyphs not being displayed properly. Added the library as a dependency and included some build scripts that are run automatically on
npm run buildThe
copy-fontawesome-cssscript is weird looking because I alter the paths required in the CSS file to match our current file structure. We currently use/fontso that is where the browser should look for font awesome fonts.I raised some related concerns in cloud-gov/cg-style-gem#5, which could change some parts of this implementation