Make owners and repos case insensitive #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Hi @gabriel-samfira, very nice .. but I think we also need to make the comparison in ValidateOwner case insensitive. The reason is that the owner in the workflow_job event will have some case and we should make it robust here. |
Github treats owners (users and orgs) and repos as case insensitive. To github, https://github.com/cloudbase/garm is equivalent to https://github.com/CloudBase/GaRm. This commit makes the sql store backend, case insensitive when querying repos and orgs. Fixes: cloudbase#25 Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
make-queries-case-insensitive
branch
from
2dd43d2
to
0ff2fd2
Compare
|
Tested with both orgs and repos: ubuntu@garm:~$ garm-cli repo ls
+--------------------------------------+-----------------+---------+------------------+
| ID | OWNER | NAME | CREDENTIALS NAME |
+--------------------------------------+-----------------+---------+------------------+
| f0b1c1c8-b605-4560-adb7-79b95e2e470c | gABrIeL-SaMfIra | ScRiPtS | gabriel |
+--------------------------------------+-----------------+---------+------------------+
ubuntu@garm:~$ garm-cli org ls
+--------------------------------------+----------+------------------+
| ID | NAME | CREDENTIALS NAME |
+--------------------------------------+----------+------------------+
| 3f7b0a5c-1d7a-4e52-b0c8-06116eca4091 | GsAmFiRa | gabriel_org |
+--------------------------------------+----------+------------------+Seems to work well. Merging. @maigl let me know if it works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github treats owners (users and orgs) and repos as case insensitive. To github, https://github.com/cloudbase/garm is equivalent to https://github.com/CloudBase/GaRm. This commit makes the sql store backend, case insensitive when querying repos and orgs.
Fixes: #25
Signed-off-by: Gabriel Adrian Samfira gsamfira@cloudbasesolutions.com