Refactor code to allow more unit testing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
requested changes
Aug 17, 2022
In order to allow mocking for some of the `runner` functions, we created a separate interface (called `PoolManagerController`) with `Create`, `Get`, `Delete` operations for the `organization` / `repository` pool managers. Furthermore, a new runner struct (`poolManagerCtrl`) implements this new interface. The existing code is refactored to use the `poolManagerCtrl` whenever the pool managers for `org` / `repo` are handled. This allows more unit testing for the runner functions since `poolManagerCtrl` field can be mocked now. Besides this, there are some typos fixed as well.
mihaelabalutoiu
force-pushed
the
refactor-code
branch
from
d49cbdb
to
7b6c2e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow mocking for some of the
runnerfunctions, we created aseparate interface (called
PoolManagerController) withCreate,Get,Deleteoperations for theorganization/repositorypool managers.Furthermore, a new runner struct (
poolManagerCtrl) implements this newinterface. The existing code is refactored to use the
poolManagerCtrlwhenever the pool managers for
org/repoare handled.This allows more unit testing for the runner functions since
poolManagerCtrlfield can be mocked now.
Besides this, there are some typos fixed as well.