Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#307 Add a sorting order for the comment retrieval #308

Merged
merged 1 commit into from
Nov 22, 2019
Merged

#307 Add a sorting order for the comment retrieval #308

merged 1 commit into from
Nov 22, 2019

Conversation

PierreBtz
Copy link
Collaborator

Fixes #307

@PierreBtz PierreBtz self-assigned this Nov 21, 2019
aheritier
aheritier approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested locally and it is fine

@aheritier aheritier merged commit 9fda174 into cloudbees-oss:master Nov 22, 2019
@aheritier aheritier added this to the 0.10.0 milestone Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheritier aheritier aheritier approved these changes

@duemir duemir Awaiting requested review from duemir duemir is a code owner

@johnou johnou Awaiting requested review from johnou

@stephenc stephenc Awaiting requested review from stephenc

Assignees

@PierreBtz PierreBtz

Labels
enhancement
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

Add support for comment retrieval in descending order
2 participants
@PierreBtz @aheritier