Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter with new types #109

Merged

Conversation

martinconstante
Copy link
Collaborator

LITE-13675 Deprecate _in filters
LITE-13315 Parameter with new types
TCR template ID optional

LITE-13315 Parameter with new types
TCR template ID optional
connect/models/schemas.py Outdated Show resolved Hide resolved
connect/resources/product.py Outdated Show resolved Hide resolved
tests/test_product.py Outdated Show resolved Hide resolved
examples/manage_asset_request.py Outdated Show resolved Hide resolved
connect/models/constraints.py Outdated Show resolved Hide resolved
connect/models/param.py Outdated Show resolved Hide resolved
connect/models/schemas.py Show resolved Hide resolved
@marcserrat marcserrat requested review from d3rky, a user and vgrebenschikov June 25, 2020 16:38
"""
if not product_id:
raise ValueError('Invalid ID')
path = '/public/v1/products/' + product_id + '/parameters/' + parameter_id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to use urljoin

@marcserrat marcserrat merged commit a75d7c1 into master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants