Fix unset variable in runtime deployment for DW VW config #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure run__dw_vw_configs is set even if run__dw_dbc_configs is unset to avoid failures later at the runtime deployment. Fixes cloudera-labs#135. Signed-off-by: Andre Araujo <araujo@cloudera.com>
jimright
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
@asdaraujo - thanks for this PR.
I hit the same issue today when deleting an environment.
I tried your changes and confirm that it works as expected.
Happy to approve based on that testing.
wmudge
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure run__dw_vw_configs is set even if run__dw_dbc_configs is unset to avoid failures later at the runtime deployment.
Fixes #135.
Signed-off-by: Andre Araujo araujo@cloudera.com