[frontend] added 'hue' to metastore url prefix when running Knox #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harshg999
approved these changes
Jan 25, 2024
Previously the hue prefix was only added if Knox was not running, which caused the back button to trigger a 404.
bjornalm
force-pushed
the
bjorn--table-browser-error-404
branch
from
50267e2
to
c42880c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the hue prefix was only added if Knox was not running,
which caused the back button to trigger a 404.
What changes were proposed in this pull request?
@wing2fly this change will overwrite some of you changes here #2111 but I think it will still work since all parts called 'hue' are removed before actually loading the data.
How was this patch tested?
Tested by manually temporary modifying the window.HUE_BASE_URL in metastoreViewModel.js and changeURL.ts to verify that HUE_BASE_URL = '/hue' would result in a url containing two 'hue' in the path. E.g. looking like hue/hue/metastore/table/default/sample_07?source_type=hive when navigating in the table browser. Because that is how the base url looks in a Knox enabled setup.
Please review Hue Contributing Guide before opening a pull request.