Fix test_sqlalchemy with sqlalchemy 2 #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did |
|
Nevermind, I create new virtualenv based on python2.7 and installed requirement from README.md. All tests pass with few warnings. I need to additionally export these two env var to pass impala/tests/test_dbapi_connect.py |
rizaon
approved these changes
Jan 29, 2024
This is normal for Python 2.7, but in my Python 3 env the version installed by default is sqlalchemy-2.0.25. This is how I bumped to this test issue. I ran the test both in Python 2.7 and 3.8 |
sqlalchemy 2 (now default on pip in Python 3) removed some functions used in tests. Updated these to work both with sqlalchemy 2.* and 1.* (>=1.2).
csringhofer
force-pushed
the
sqlalchemy_test_fix
branch
from
1c736a1
to
f7a372f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlalchemy 2 (now default on pip) removed some functions used in tests. Updated tests to work both with sqlalchemy 2.* and 1.* (>=1.2).