Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(nuget): make dotnet pack deterministic #213

Merged
merged 1 commit into from
Jun 24, 2022
Merged

ci(nuget): make dotnet pack deterministic #213

merged 1 commit into from
Jun 24, 2022

Conversation

skyfrk
Copy link
Contributor

@skyfrk skyfrk commented Jun 22, 2022

This should solve #175 according to this blog post.

Alternatively one could also add

<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
  <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>

to src/Directory.Build.props.

@skyfrk
ci(nuget): make dotnet pack deterministic
c6c5245 
by adding the flag `-p:ContinuousIntegrationBuild=true`

Signed-off-by: Simon Eßlinger <github@esslinger.dev>
jskeet
jskeet approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for looking into this!

@jskeet jskeet merged commit e517ee4 into cloudevents:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyfrk @jskeet