Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete OLDOCS.md #63

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Delete OLDOCS.md #63

merged 1 commit into from
Apr 27, 2020

Conversation

grant
Copy link
Member

@grant grant commented Apr 25, 2020

There's no need to keep old docs around an old spec version in the master branch. Git history will keep them.

@grant
Delete OLDOCS.md
fc1cb7f 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant mentioned this pull request Apr 25, 2020
Closed
@grant
Copy link
Member Author

grant commented Apr 25, 2020

Hi @fabiojose,
I request you as a reviewer until I am listed as a collaborator to this repo. Can you review this PR?
–Grant

@fabiojose
Copy link
Contributor

Good for you @grant
LGTM

@grant
Copy link
Member Author

grant commented Apr 25, 2020 •
edited
Loading

Thanks! Let me know what I can do to have this merged.

@grant
Copy link
Member Author

grant commented Apr 27, 2020

Hi @fabiojose,
Can we approve and merge this? I hope to work on this library this week.

@fabiojose fabiojose merged commit bb9b211 into cloudevents:master Apr 27, 2020
@grant
Copy link
Member Author

grant commented Apr 27, 2020

Thanks!

@grant grant deleted the patch-1 branch April 27, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grant @fabiojose