Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actix-web 4 #114

Closed
ctron opened this issue Feb 9, 2021 · 3 comments
Closed

Use actix-web 4 #114

ctron opened this issue Feb 9, 2021 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@ctron
Copy link
Contributor

ctron commented Feb 9, 2021

Although actix-web 4 is only released as beta yet, it is required for the switch to tokio 1.

@slinkydeveloper
Copy link
Member

I see it's still in beta https://github.com/actix/actix-web/releases/tag/web-v4.0.0-beta.1, I would love to wait for the final release before updating it here. How does it sounds?

@slinkydeveloper slinkydeveloper added the dependencies Pull requests that update a dependency file label Feb 9, 2021
ctron added a commit to ctron/sdk-rust that referenced this issue Feb 9, 2021
@andrewwebber
Copy link
Contributor

andrewwebber commented Apr 8, 2021

Also observing this, would be great to have a branch somewhere to test. For example using OpenTelemetry in Rust requires Tokio1 and I would love to confirm that OpenTel + ActixWeb + Cloudevents = ❤️

@andrewwebber
Copy link
Contributor

@ctron Thank you for putting together your fork

jcrossley3 added a commit that referenced this issue Jul 23, 2021
jcrossley3 added a commit that referenced this issue Jul 23, 2021
Fixes #114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit that referenced this issue Sep 9, 2021
Fixes #114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit to jcrossley3/sdk-rust that referenced this issue Sep 10, 2021
Fixes cloudevents#114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit that referenced this issue Sep 10, 2021
Fixes #114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit that referenced this issue Dec 16, 2021
Fixes #114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit that referenced this issue Dec 16, 2021
Fixes #114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit to jcrossley3/sdk-rust that referenced this issue Jan 7, 2022
Fixes cloudevents#114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit to jcrossley3/sdk-rust that referenced this issue Jan 14, 2022
Fixes cloudevents#114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit to jcrossley3/sdk-rust that referenced this issue Jan 14, 2022
Fixes cloudevents#114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit to jcrossley3/sdk-rust that referenced this issue Jan 24, 2022
Fixes cloudevents#114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit that referenced this issue Feb 11, 2022
Fixes #114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit to jcrossley3/sdk-rust that referenced this issue Feb 27, 2022
Fixes cloudevents#114

Signed-off-by: Jim Crossley <jim@crossleys.org>
jcrossley3 added a commit to jcrossley3/sdk-rust that referenced this issue Feb 28, 2022
Fixes cloudevents#114

Signed-off-by: Jim Crossley <jim@crossleys.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants