Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary clones #224

Merged
merged 1 commit into from
Apr 19, 2024
Merged

remove unnecessary clones #224

merged 1 commit into from
Apr 19, 2024

Conversation

DirkRusche
Copy link
Contributor

Just stumbled over this clone today.

By first calling attribute_names() the clone becomes unnecessary.

<insert "It's not much, but it is honest work" meme>

Signed-off-by: Dirk Rusche <dirk@rusche.me>
Copy link
Member

@Lazzaretti Lazzaretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @DirkRusche !

@Lazzaretti Lazzaretti merged commit 1978ae1 into cloudevents:main Apr 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants