V0.3 implementation #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
linuxbasic
approved these changes
Apr 10, 2020
slinkydeveloper
added a commit
that referenced
this pull request
Apr 10, 2020
* Added String variant to Data Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Started V0.3 work Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reworked EventDeserializer trait Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now event parsing works with v1 and changes Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reorganized test data Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixed serde for v03 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Implemented spec version conversion Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
pranav-bhatt
pushed a commit
to pranav-bhatt/sdk-rust
that referenced
this pull request
Apr 29, 2020
* Added String variant to Data Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Started V0.3 work Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reworked EventDeserializer trait Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now event parsing works with v1 and changes Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reorganized test data Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixed serde for v03 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Implemented spec version conversion Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
slinkydeveloper
added a commit
that referenced
this pull request
Apr 29, 2020
* Started working on message module Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * just to align with other sdks (#21) Signed-off-by: Doug Davis <dug@us.ibm.com> * add link to email (#22) Signed-off-by: Doug Davis <dug@us.ibm.com> * Implemented custom deserialization process Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Implemented custom serialization process Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * V0.3 implementation (#24) * Added String variant to Data Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Started V0.3 work Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reworked EventDeserializer trait Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now event parsing works with v1 and changes Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reorganized test data Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixed serde for v03 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Implemented spec version conversion Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * WIP implementing serialization/deserialization for messages Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Adjusted some wrong merge changes Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Rename Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: Doug Davis <dug@us.ibm.com>
pranav-bhatt
pushed a commit
to pranav-bhatt/sdk-rust
that referenced
this pull request
Apr 30, 2020
* Added String variant to Data Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Started V0.3 work Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reworked EventDeserializer trait Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Now event parsing works with v1 and changes Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Reorganized test data Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Fixed serde for v03 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Implemented spec version conversion Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * cargo fmt Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5, #4, #3
In future i would love to explore a macro to remove some boilerplate here and there for the Attribute struct. Also reorganized serde tests