change SIOCGIFMTU type to i32 (musl ioctl) #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkrasnov
reviewed
Mar 28, 2019
| @@ -45,6 +45,9 @@ pub struct ifreq { | |||
| ifr_ifru: IfrIfru, | |||
| } | |||
|
|
|||
| #[cfg(target_env = "musl")] | |||
| const SIOCGIFMTU: int32_t = 0x8921; | |||
There was a problem hiding this comment.
I think the best way to handle it is to cast using 'as _' wherever SIOCGIFMTU is used.
|
Actually this is something the libc crate should handle, IMHO. But as soon as I find out how to cast 'as i32' on musl only in an elegant way I will try that, thanks! |
This was referenced Mar 30, 2019
|
So indeed musl defines the ioctl parameter as an int, and apparently that is what POSIX specifies according to https://bugs.freedesktop.org/show_bug.cgi?id=85319. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ioctl function signature differs on glibc and musl libc.
extern int ioctl (int __fd, unsigned long int __request, ...) __THROW;
vs.
int ioctl (int, int, ...);
To avoid mismatched types errors on musl I shamelessly copied tun_darwin.rs' definition of SIOCGIFMTU.