Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-fuzz for CIRCL #4

Closed
kriskwiatkowski opened this issue Feb 13, 2019 · 13 comments
Closed

go-fuzz for CIRCL #4

kriskwiatkowski opened this issue Feb 13, 2019 · 13 comments
Labels
good first issue help wanted Extra attention is needed

Comments

@kriskwiatkowski
Copy link
Contributor

kriskwiatkowski commented Feb 13, 2019

We should use both:

Obviously it can't be part of the CI as it will disturb development process. os-fuzz is much better place

@claucece
Copy link
Contributor

claucece commented Jun 4, 2020

Very interesting. I can start playing with this a little.

@kriskwiatkowski
Copy link
Contributor Author

kriskwiatkowski commented Jun 4, 2020

oh, while I'm here. I was recently informed by the author via linkedin that this exists and uses CIRCL
https://github.com/kuking/go-pqsw

thought you may want to know

@claucece
Copy link
Contributor

claucece commented Jul 4, 2020

Oh, wow, interesting @henrydcase .. check it out @bwesterb : https://github.com/kuking/go-pqsw

@guidovranken
Copy link

Hey @henrydcase @claucece , I'm the maintainer of Cryptofuzz. I'm still improving it every day. It now supports elliptic curve operations and has been effective at finding EC bugs (see full bug list here ). PQ crypto not yet but I'm planning on implementing that. Have you gotten around to work with Cryptofuzz to test circl? Feel free to reach out to me at guido@guidovranken.com to discuss these plans in depth.

@armfazh
Copy link
Contributor

armfazh commented Nov 23, 2020

Fuzzing is something we want to include in CIRCL, we are open for discussion.
thanks for the pointer @guidovranken

@armfazh armfazh added good first issue help wanted Extra attention is needed labels Nov 23, 2020
@guidovranken
Copy link

I now have a circl module for Cryptofuzz https://github.com/guidovranken/cryptofuzz/tree/master/modules/circl
It found one bug so far #312

I can install it on OSS-Fuzz if you want @armfazh ?

@armfazh
Copy link
Contributor

armfazh commented Feb 2, 2022

I now have a circl module for Cryptofuzz https://github.com/guidovranken/cryptofuzz/tree/master/modules/circl It found one bug so far #312

Thanks for writing the module.

I can install it on OSS-Fuzz if you want @armfazh ?

What does this implies and what it is required to be included? (sorry, not so familiar with the internals of the project).

@guidovranken
Copy link

Basically:

  • Requires participants to have a Google account. I need a list of e-mail addresses (linked to a Google account) of maintainers. Note: these will be public
  • You will receive an e-mail notification when a bug is found, and when it is detected as fixed
  • There is an expectation that bugs found by OSS-Fuzz will be fixed by the maintainers (you)
  • Bugs found remain private for 90 days, then they are automatically publicly disclosed whether they are fixed or not
  • "To be accepted to OSS-Fuzz, an open-source project must have a significant user base and/or be critical to the global IT infrastructure."
  • Usage of OSS-Fuzz is free of charge
  • I will collect the $1,000 integration reward

More information: https://google.github.io/oss-fuzz/

@chris-wood
Copy link
Contributor

Requires participants to have a Google account. I need a list of e-mail addresses (linked to a Google account) of maintainers. Note: these will be public

@guidovranken can you please clarify who the "participants" are here?

@guidovranken
Copy link

People who receive the bug reports, typically the maintainers of the software being fuzzed, in this case the circl maintainers.

@armfazh
Copy link
Contributor

armfazh commented Feb 10, 2022

@guidovranken just reached at this address https://guidovranken.com/contact/, please confirm you have received my email.

@guidovranken
Copy link

Yes I did, thanks, I will reply in a minute.

@armfazh
Copy link
Contributor

armfazh commented Feb 10, 2022

Tracking integration at: google/oss-fuzz#7262

ilway25 pushed a commit to chelpis/circl that referenced this issue Aug 29, 2024
* - adds META.yml files
- adds new api: crypto_sign_signature and crypto_sign_verify
- adds namespacing
- converts CRLF to LF
- fixes for big-endian
- changes types from 'unsigned long long' to size_t
- fixes for strict compilers
- ensures newlines at end of files
- remove PQM4 defines from api, using size_t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants