Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

origin_ca: remove the restriction of using API service keys #1161

Merged

Conversation

jacobbednarz
Copy link
Member

@jacobbednarz jacobbednarz commented Jan 3, 2023

The team has made strides in removing the restriction of only using the API user service keys for origin CA requests so we can now pass in any auth scheme the end user requires.

Method updates:

  • renamed to CreateOriginCertificate to CreateOriginCACertificate
  • renamed to OriginCertificates to ListOriginCACertificates
  • renamed to OriginCertificate to GetOriginCACertificate
  • renamed to RevokeOriginCertificate to RevokeOriginCACertificate
  • renamed to OriginCARootCertificate to GetOriginCARootCertificate

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #1161 (8802b7f) into master (6153c1e) will decrease coverage by 0.09%.
The diff coverage is 56.72%.

@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
- Coverage   49.40%   49.31%   -0.10%     
==========================================
  Files         127      128       +1     
  Lines       12290    12402     +112     
==========================================
+ Hits         6072     6116      +44     
- Misses       4840     4885      +45     
- Partials     1378     1401      +23     
Impacted Files Coverage Δ
utils.go 72.72% <ø> (ø)
mtls_certificates.go 26.59% <26.59%> (ø)
origin_ca.go 57.26% <90.90%> (-2.09%) ⬇️
dns.go 68.69% <92.45%> (+4.97%) ⬆️
email_routing_destination.go 66.66% <100.00%> (+0.41%) ⬆️
email_routing_rules.go 65.64% <100.00%> (+0.26%) ⬆️
filter.go 43.38% <100.00%> (+0.41%) ⬆️
firewall_rules.go 54.38% <100.00%> (+0.40%) ⬆️
lockdown.go 58.22% <100.00%> (+0.53%) ⬆️
queue.go 72.02% <100.00%> (+0.29%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member Author

cc @maxnystrom

The team has made strides in removing the restriction of only using the
API user service keys for origin CA requests so we can now pass in any
auth scheme the end user requires.
@jacobbednarz jacobbednarz force-pushed the support-tokens-for-origin-certs branch from b54a5d9 to 8802b7f Compare January 3, 2023 03:57
@jacobbednarz jacobbednarz merged commit 6adbcf7 into cloudflare:master Jan 4, 2023
@github-actions github-actions bot added this to the v0.58.0 milestone Jan 4, 2023
github-actions bot pushed a commit that referenced this pull request Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

This functionality has been released in v0.58.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jacobbednarz jacobbednarz deleted the support-tokens-for-origin-certs branch January 4, 2023 23:40
@jacobbednarz
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants