Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for body_scanning (Enhanced File Detection) in teams account configuration #1423

Conversation

webbgeorge
Copy link
Contributor

@webbgeorge webbgeorge commented Oct 19, 2023

Add support for body_scanning (Enhanced File Detection) in teams account configuration.

Description

The teams account configuration APIs support Enhanced File Detection (body_scanning in the API), see links below. This PR adds support for this parameter with the Go SDK - with a view to implement the same functionality on the Terraform provider once released.

No issue raised as this feels like a minor addition. Happy to raise one if requested.

Has your change been tested?

Unit tests have been updates, and additionally I created a test Go app to confirm the changes work with both get and update functionality, using own Cloudflare account.

Screenshots (if appropriate):

N/A

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

lgtm, thank you for the contribution! 👏

@jacobbednarz jacobbednarz merged commit af6d964 into cloudflare:master Oct 22, 2023
13 checks passed
@github-actions github-actions bot added this to the v0.80.0 milestone Oct 22, 2023
github-actions bot pushed a commit that referenced this pull request Oct 22, 2023
@webbgeorge webbgeorge deleted the teams-account-enhanced-file-detection branch October 23, 2023 08:06
@github-actions
Copy link
Contributor

This functionality has been released in v0.80.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants