Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change LogScope to use an _inner field instead of allow(dead_code) #39

Closed
nox opened this issue Mar 21, 2024 · 0 comments · Fixed by #55
Closed

Change LogScope to use an _inner field instead of allow(dead_code) #39

nox opened this issue Mar 21, 2024 · 0 comments · Fixed by #55

Comments

@nox
Copy link
Collaborator

nox commented Mar 21, 2024

#38
inikulin added a commit that referenced this issue Jul 18, 2024
@inikulin
Telemetry API improvements
a447775 
- Provide API to transform `SpanScope` into `TelemetryContext`. That allows ergonomically apply span scopes returned by `start_trace` to futures. In addition, it allows us to get rid of `TelemetryContext::apply_with_tracing_span` and alike
- Add telemetry instrumentation support for `!Send` futures
- Remove usages of `#[allow(dead_code)]` (closes #39)
@inikulin inikulin mentioned this issue Jul 18, 2024
Merged
inikulin added a commit that referenced this issue Jul 18, 2024
@inikulin
Telemetry API improvements
01057b4 
- Provide API to transform `SpanScope` into `TelemetryContext`. That allows ergonomically apply span scopes returned by `start_trace` to futures. In addition, it allows us to get rid of `TelemetryContext::apply_with_tracing_span` and alike
- Add telemetry instrumentation support for `!Send` futures
- Remove usages of `#[allow(dead_code)]` (closes #39)
inikulin added a commit that referenced this issue Jul 18, 2024
@inikulin
Telemetry API improvements
860c887 
- Provide API to transform `SpanScope` into `TelemetryContext`. That allows ergonomically apply span scopes returned by `start_trace` to futures. In addition, it allows us to get rid of `TelemetryContext::apply_with_tracing_span` and alike
- Add telemetry instrumentation support for `!Send` futures
- Remove usages of `#[allow(dead_code)]` (closes #39)
inikulin added a commit that referenced this issue Jul 19, 2024
@inikulin
Telemetry API improvements
2606168 
- Provide API to transform `SpanScope` into `TelemetryContext`. That allows ergonomically apply span scopes returned by `start_trace` to futures. In addition, it allows us to get rid of `TelemetryContext::apply_with_tracing_span` and alike
- Add telemetry instrumentation support for `!Send` futures
- Remove usages of `#[allow(dead_code)]` (closes #39)
inikulin added a commit that referenced this issue Jul 19, 2024
@inikulin
Telemetry API improvements
3d2f11a 
- Provide API to transform `SpanScope` into `TelemetryContext`. That allows ergonomically apply span scopes returned by `start_trace` to futures. In addition, it allows us to get rid of `TelemetryContext::apply_with_tracing_span` and alike
- Add telemetry instrumentation support for `!Send` futures
- Remove usages of `#[allow(dead_code)]` (closes #39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Telemetry API improvements cloudflare/foundations
1 participant
@nox