Add support for OTLP tracing reporting #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikulin
force-pushed
the
tracing-exporters
branch
2 times, most recently
from
f7307e8
to
c37827b
Compare
cbranch
reviewed
Mar 13, 2024
| #[cfg(feature = "telemetry-server")] | ||
| server_fut: Option<TelemetryServerFuture>, | ||
|
|
||
| tele_futures: FuturesUnordered<BoxFuture<'static, BootstrapResult<()>>>, |
There was a problem hiding this comment.
if this is always going to have one future, why is this different from server_fut
There was a problem hiding this comment.
No, in the upcoming PRs it will be also used to drive exporters.
cbranch
approved these changes
Mar 13, 2024
This allows to get rid of 2 separate functions for telemetry initialisation and allows to drive async functionality other than just the telemetry server.
…with logging settings
inikulin
force-pushed
the
tracing-exporters
branch
from
095665d
to
67db5f8
Compare
- Use async reporting for traces by using rustracing fork - Scaffold gRPC reporter - Fix defaults for settings - make serde(default) attributes unconditional, otherwise they were not parsed by our macro
inikulin
force-pushed
the
tracing-exporters
branch
3 times, most recently
from
9371eba
to
28ac05a
Compare
inikulin
changed the title
inikulin
force-pushed
the
tracing-exporters
branch
4 times, most recently
from
81b3e54
to
767ae02
Compare
inikulin
force-pushed
the
tracing-exporters
branch
from
767ae02
to
741bd97
Compare
| if ready_res.is_empty() { | ||
| Poll::Pending | ||
| } else { | ||
| Poll::Ready(ready_res.into_iter().collect()) |
There was a problem hiding this comment.
Is completing after the first polled future finishes the intended behavior here?
There was a problem hiding this comment.
Yes. There are 2 cases where either of those complete:
- TelemetryServer received a graceful shutdown signal. Once it finishes we wrap up all operations, including telemetry reporting
- Any of those error - one of the components of the telemetry system is not functioning anymore, we need to terminate.
Noah-Kennedy
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's recommended to review the commits in the PR separately