This repository has been archived by the owner on Mar 21, 2020. It is now read-only.
KEY-56 - Checkout do_ssl_handshake error and close if fatal #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Shouldn't we also add logging for the other |
|
Uh. Yes, we should. I thought it was being logged but alas the error is just being cleared and the connection terminated. I will update this pull request. |
Previously, the first call to do_ssl_handshake was assume to 'work' (i.e. return WANT_READ or WANT_WRITE) and the error code was not checked. Added checking of the error code and if it is not retriable then drop the connection and log the error.
|
Updated. |
|
Looks good, feel free to merge it. |
Previously, connection_terminate handled SSL_shutdown return codes poorly and assumed that SSL_shutdown would work (it retried it once). This could lead to a situation where SSL_shutdown returned WANT_READ or WANT_WRITE which would be ignored and then the TCP connection terminated. Now each connection has a TERMINATING state added and it will continue to process reads and call SSL_shutdown repeatedly on read events until the connection has been terminated. Only then will memory be cleaned up and the TCP connection killed.
grittygrease
added a commit
that referenced
this pull request
Dec 15, 2014
KEY-56 - Checkout do_ssl_handshake error and close if fatal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the first call to do_ssl_handshake was assume to 'work'
(i.e. return WANT_READ or WANT_WRITE) and the error code
was not checked. Added checking of the error code and if it is not
retriable then drop the connection and log the error.